Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: OBSStudio returns incorrect download URI for OBS releases with patch versions of 0 #445

Closed
2 tasks done
blu3id opened this issue Jan 14, 2023 · 3 comments · Fixed by #446
Closed
2 tasks done
Labels
bug Something isn't working

Comments

@blu3id
Copy link
Contributor

blu3id commented Jan 14, 2023

What happened?

The download URI returned for the current release of OBS is incorrect because OBS only use major.minor version numbers (e.g 29.0) on binary releases when the patch version is equal to 0.

Evergreen returns a URI of: https://cdn-fastly.obsproject.com/downloads/OBS-Studio-29.0.0-Full-Installer-x86.exe but checking on the OBS website the correct URI is: https://cdn-fastly.obsproject.com/downloads/OBS-Studio-29.0-Full-Installer-x64.exe

While this is an edge case I don't think this is unique to this release as if you review the assets on previous release e.g https://github.com/obsproject/obs-studio/releases/tag/28.1.0 the binaries follow a similar pattern of omitting the patch version using only major.minor

Version

2301.717

What PowerShell edition/s are you running Evergreen on?

Windows PowerShell

Which operating system/s are you running Evergreen on?

Windows 10

Have you reviewed the documentation?

Verbose output

n/a
@blu3id blu3id added the bug Something isn't working label Jan 14, 2023
aaronparker added a commit that referenced this issue Jan 14, 2023
@aaronparker
Copy link
Owner

Looking good; however, the x86 version link looks to be unavailable:

PS /Users/aaron/projects/evergreen> Get-EvergreenApp -Name "OBSStudio"

Version Architecture URI
------- ------------ ---
29.0    x64          https://cdn-fastly.obsproject.com/downloads/OBS-Studio-29.0-Full-Installer-x64.exe
29.0    x86          https://cdn-fastly.obsproject.com/downloads/OBS-Studio-29.0-Full-Installer-x86.exe

PS /Users/aaron/projects/evergreen> Get-EvergreenApp -Name "OBSStudio" | Test-EvergreenApp

Result URI
------ ---
  True https://cdn-fastly.obsproject.com/downloads/OBS-Studio-29.0-Full-Installer-x64.exe
 False https://cdn-fastly.obsproject.com/downloads/OBS-Studio-29.0-Full-Installer-x86.exe

@aaronparker
Copy link
Owner

Looks like the x86 installer is no longer available, so we could remove that.

@blu3id
Copy link
Contributor Author

blu3id commented Jan 16, 2023

Good spot missed that. Have added further PR removing architecture from manifest as the "least restrictive" option making it easy to add back if x86 becomes available again or if (more likely) another architecture is added e.g ARM. Downside is leaves currently unneeded ForEach loop in Get-OBSStudio.ps1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants