-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<script> and <iframe> tags should be returned as-is #45
Comments
👍 for this one. |
-1 from me ... html2text IMHO should be kept to the minimum. If you need anything more complicated, go and pre-/post-process its input/output. |
The problem is that if you want to convert HTML from Wordpress to a Jekyll Markdown, you want to preserve script and iframe tags. They will be lost afterwards. You could create a parser that replaces them by a marker string and replace that marker string after the conversion, but it would be way nicer if this lib has an option for this. And less error prone. |
What in the world is the point of storing iframes in Jekyll? Anyway, some escaping of HTML elements ('<' => <) should be sufficient shouldn't it? That's what I meant as pre-/post-processing. |
What is the point? Maybe I just want to preserve youtube iframes when converting my blog 😉 . Escape the HTML elements is really bad and is very error prone. Why do all this ugyl workarounds when html2text can do this easily. |
Currently html2text does everything in one place, I guess @mcepl is right about pre-/post-processing. We need to implement such a functionality to enable other control that behavior and do what ever they want to without touching html2text directly and make the stuff dirty. Of course we can pass any tag to prevent removing them and have an option on html2text but all these stuff would make it ugly as possible. After all my -1 vote for this issue. |
…andard-input-when-running-under-python-3 Fix aaronsw#45 does not accept standard input when running under python 3 Fixes aaronsw#45 Thanks to: * Mark Blakeney @bulletmark * @djr7C4 * @willemw12
No description provided.
The text was updated successfully, but these errors were encountered: