Added additional HTML entities for ascii conversion. #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanor
added a commit
to stefanor/html2text
that referenced
this pull request
Jan 14, 2016
We can't use the new default, until we stop supporting all versions of Python that don't accept this argument (it appeared in 3.4) Fixes: aaronsw#89
stefanor
added a commit
to stefanor/html2text
that referenced
this pull request
Jan 14, 2016
We can't use the new default, until we stop supporting all versions of Python that don't accept this argument (it appeared in 3.4) Fixes: aaronsw#89
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into a
UnicodeEncodeErrortrying to save an ascii file created by html2text. Turns out there were a few valid HTML entities we were using that were not being converted properly. This small commit adds those missing entities.Thanks for taking a look.