-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Gradles "Task Configuration Avoidance" which requires Gradle >= 4.9 #30
Use Gradles "Task Configuration Avoidance" which requires Gradle >= 4.9 #30
Conversation
@larsgrefer thanks for PR. What's the purpose of this change? I tried to have the minimal working Gradle verison in the wrapper and your changes does not require any update here - as far as I could see? |
Updating to 4.10.3 allows the plugin to be built on Java 11. |
Correct, but the pre-build and provided jar runs with Java 11 and Gradle > 3.5.1. Therefore this is only an issue for the travis-ci build, right? |
…into update/gradle/4.10.3
Gradle 3.5.1 is nearly two years old. I thought it might be time to move things a bit forward. Updating to a newer Gradle version paves the way for new Gradle API's like
The Java 11 issue also affected my local machine. I've had to install Java 8 in order to work on #31 |
Understood, to work on this plugin you need to have Java 8 right now. To run it Java 11 is perfectly OK. Do you have any use-cases for "lazy configuration" and "task configuration avoidance" which you would like to introduce in this plugin? Travis build: The Java 11 build is unfortunately still broken. Upon first view it seems to be an issue on JaCoCo: |
Thanks for your effort @larsgrefer. I like the changes and I would like to merge them :-) Do you have an idea about the Java 11 build problems? Could it be that PMD support Java 11 from 6.6.0 on? |
Hi @larsgrefer, thanks for your PR. Even if creation of |
I hereby agree to the terms of the Gradle CPD plugin Contributor License Agreement.