Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The 'check' task is introduced by LifecycleBasePlugin #31

Merged
merged 2 commits into from Mar 10, 2019
Merged

The 'check' task is introduced by LifecycleBasePlugin #31

merged 2 commits into from Mar 10, 2019

Conversation

larsgrefer
Copy link
Contributor

The 'check' task is not added by the JavaBasePlugin, but by LifecycleBasePlugin. Therefore the latter should be used, to detect its presence.

@aaschmid
Copy link
Owner

aaschmid commented Mar 4, 2019

@larsgrefer: Thanks for this improvement. With which versions have you tested this change?

@larsgrefer
Copy link
Contributor Author

I'll have a look at the failing test on travis.

@larsgrefer larsgrefer mentioned this pull request Mar 5, 2019
Merged
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.714% when pulling cbb488d on larsgrefer:feature/LifecycleBasePlugin into 4f0cda8 on aaschmid:master.

@aaschmid
Copy link
Owner

aaschmid commented Mar 7, 2019

Thanks @larsgrefer, I will have a deeper look :-)

Are these changes urgent for you in any case?

@aaschmid aaschmid merged commit fd69ba6 into aaschmid:master Mar 10, 2019
@aaschmid aaschmid self-assigned this Apr 17, 2019
@aaschmid aaschmid added this to the v1.3 milestone Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aaschmid aaschmid

Labels
accepted fixed
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@larsgrefer @aaschmid @coveralls