Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout issues with TextSkittle #18

Closed
ligi opened this issue Jan 31, 2016 · 5 comments
Closed

Layout issues with TextSkittle #18

ligi opened this issue Jan 31, 2016 · 5 comments

Comments

@ligi
Copy link
Contributor

ligi commented Jan 31, 2016

Icon-Only skittles work fine but when using one with text there are 2 problems:

skittles_problem

a) the shadow is cropped
b) the text is not centered vertically

with this code:

  final SkittleBuilder builder = new SkittleBuilder.Builder(this, fam)
                .mainSkittleColor( R.color.accent)
                .build();


        builder.makeTextSkittle("foo",R.drawable.ic_action_bulb).add();
@ghost
Copy link

ghost commented Feb 1, 2016

Noted
On 01-Feb-2016 1:52 AM, "ligi" notifications@github.com wrote:

Icon-Only skittles work fine but when using one with text there are 2
problems:

[image: skittles_problem]
https://cloud.githubusercontent.com/assets/111600/12704692/80e315d0-c860-11e5-9378-30fa60b00850.png

a) the shadow is cropped
b) the text is not centered vertically

with this code:

final SkittleBuilder builder = new SkittleBuilder.Builder(this, fam)
.mainSkittleColor( R.color.accent)
.build();

    builder.makeTextSkittle("foo",R.drawable.ic_action_bulb).add();


Reply to this email directly or view it on GitHub
#18.

@ghost
Copy link

ghost commented Feb 4, 2016

Checkout the new version 3.0.0 it fixes everything, NOTE: the new version has breaking changes refer to the readme for the changes or feel free to raise an issue

@ligi
Copy link
Contributor Author

ligi commented Feb 4, 2016

having a problem using 3.0.0:

* What went wrong:
A problem occurred configuring project ':mobile'.
> Could not resolve all dependencies for configuration ':mobile:_debugCompile'.
   > Could not resolve com.rlj.library:skittles:3.0.0.
     Required by:
         VaporizerControl:mobile:unspecified
      > Could not resolve com.rlj.library:skittles:3.0.0.
         > inconsistent module metadata found. Descriptor: com.rlj.library:skittles:3.0.0-SNAPSHOT Errors: bad version: expected='3.0.0' found='3.0.0-SNAPSHOT'


@ghost
Copy link

ghost commented Feb 5, 2016

Hmm seems like the artifact wasn't published correctly I have uploaded a new version 4.0.0, I tested it should work correctly thanks for your patiece

@ligi
Copy link
Contributor Author

ligi commented Feb 5, 2016

Looks better now - but why did you jump a whole major for this ?-)

@ligi ligi closed this as completed Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant