#24 - fixes tests failing in travis

[rahgurung]

used pip liked earlier

[rahgurung]

@aashutoshrathi yeah moving back to pip from pip3 fixed the tests.

[aashutoshrathi]

Can you also add to deploy only if branch is master

[rahgurung]

;) https://travis-ci.org/aashutoshrathi/git-profiler-bot/jobs/471846613 tests passed, merging this will pass the build , I promise.

Travis CI - Test and Deploy Your Code with Confidence

[rahgurung]

Can you also add to deploy only if branch is master

that's exactly what we need.

[aashutoshrathi]

Yes, just a single if in travis.
And also add the command sls deploy to after succes

[aashutoshrathi]

Check comments, do something like that

[aashutoshrathi]

That's weird tests failed again.

But do one thing before pytest.
Create a file named serverless.env.yml and these contents into it

TELEGRAM_TOKEN: ${TELEGRAM_TOKEN}
CONTRI_API: ${CONTRI_API}

[aashutoshrathi]

Travis gave up?

[rahgurung]

nah , it was error in my yml.

[aashutoshrathi]

If result return 404 add a separate test for that.

[aashutoshrathi]

@gurungrahul2 doing it?

[rahgurung]

yeah ! will continue after a break.

[aashutoshrathi]

I think we need to be quick with this PR, also in process commits, please comment sls deploy, else bot will stop working for a while

[aashutoshrathi]

Use this: https://stackoverflow.com/a/53130965/7326407

Stack Overflow

Travis-CI deploy every master commit, but not branch commits

I have set up travis to test my project, and to deploy a docker build for every commit.

What I really want to do, is to test every commit I have, and only when it is being rebased to master, deplo...

[rahgurung]

but deploy is fine, do we really wanna do this?

[aashutoshrathi]

Yes, we need to do this.

[aashutoshrathi]

Please squash

[rahgurung]

sure

[aashutoshrathi]

Please squash all commits into one

[aashutoshrathi]

Before doing another commit please squash all commits in one.

[rahgurung]

@aashutoshrathi sure.

[aashutoshrathi]

Also, add deploy tab

[aashutoshrathi]

Add that cat command too, which creates serverless file, I think I will need to rewrite tests.

[aashutoshrathi]

Let the tests fail, because they are wrong due to change of code

[rahgurung]

Let the tests fail, because they are wrong due to change of code

only two tests are failing for me.

[rahgurung]

why tests are passing on my local machine ?

[rahgurung]

@aashutoshrathi I have commented two cases which are failing unexpectedly, everything else looks fine.

[rahgurung]

Have a look at log, https://travis-ci.org/aashutoshrathi/git-profiler-bot/builds/472058814 I think type empty is matched with User , and in Email empty with none. @aashutoshrathi

Travis CI - Test and Deploy Your Code with Confidence

[aashutoshrathi]

Do this please #26 (comment)

[aashutoshrathi]

Also remove these lines completely.

[aashutoshrathi]

Do this please #26 (comment)
Else, bot won't work on deploy.