Silence method override warning when it's an enum #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nathanstitt Hmm, I saw #346 first and merged it already. But I agree that your approach is more complete and would like to add it, too. Do you want to merge master back into (and resolve the conflicts)? I'm happy to do it, just let me know 👍 |
|
Sure, just did so. Thanks! |
|
@nathanstitt Cheers! |
|
@nathanstitt I just released version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This silences the
overriding method xxxx!warning that's emitted when the overridden method came from an enum.I didn't notice #346 when I created this, but but this may be a better approach since it actually checks for defined enums using
defined_enums(if present)