Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 132 #181

Merged
merged 7 commits into from
Apr 20, 2020
Merged

Fixes 132 #181

merged 7 commits into from
Apr 20, 2020

Conversation

nicolaibjerring
Copy link
Contributor

Fixes #132 : Added licenses for all files used in the GIRAF platform

All licenses for all files used in the GIRAF platform is now available in the wiki-repository under security/licenses.md. This file should be updated during development whenever a new icon or sound, etc., is used.

@nicolaibjerring nicolaibjerring added this to the 2020S2 milestone Apr 20, 2020
@mads-bo mads-bo requested review from a team April 20, 2020 11:16
Copy link
Contributor

@mads-bo mads-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aau-giraf/sw611f20 you have been assigned this. Here's your checklist.

Please use the following checklist:

Code Documentation Only

  • It is documented which BLoCs/Screens the current class is related to
  • The responsibility/functionality of the current class is explained. Also regarding the classes it is related to
  • If any unusual decisions are introduced in the code, they reasoned about in the documentation

Wiki Related

  • There are no dead links or references
  • The markdown renders correctly in MkDocs
  • The content is placed in the correct page/folder/section

You can run MkDocs locally by following this guide

Copy link
Contributor

@mads-bo mads-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aau-giraf/sw617f20 you have been assigned this. Here's your checklist.

Please use the following checklist:

Code Documentation Only

  • It is documented which BLoCs/Screens the current class is related to
  • The responsibility/functionality of the current class is explained. Also regarding the classes it is related to
  • If any unusual decisions are introduced in the code, they reasoned about in the documentation

Wiki Related

  • There are no dead links or references
  • The markdown renders correctly in MkDocs
  • The content is placed in the correct page/folder/section

You can run MkDocs locally by following this guide

@nicolaibjerring nicolaibjerring merged commit f93b559 into master Apr 20, 2020
@nicolaibjerring nicolaibjerring deleted the fixes_132 branch April 20, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants