Re-implementing Parser: Add support for multi-document tag directives #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 17, 2015 16:20
…tag directives - especially to aid reading Unity scene files
If the type could not be loaded, because it fails with an exception, make sure to return false to pass resolving to the next resolver in the list.
|
See also #140 |
|
This looks good, thanks! There was the question of the different behavior in YAML 1.2, but I think we can leave that for later. There is just an issue with the formatting. This project uses tabs instead of spaces, and your changes are using spaces, which messes-up the alignment of blocks. Could you update the PR with tabs instead of spaces? PS: I know that most people prefer to use spaces instead of tabs. I have opened a separate issue, #143 to discuss a possible move to that convention. Feel free to leave a comment there. |
|
I made the changes myself because I had to resolve a merge conflict. |
|
Ok, thanks a lot, I wasn't in reach of a PC this weekend :) 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially to aid reading Unity scene files
Original PR #102