Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: etherfi market [skip cypress] #2172

Merged
merged 6 commits into from
Sep 9, 2024
Merged

feat: etherfi market [skip cypress] #2172

merged 6 commits into from
Sep 9, 2024

Conversation

grothem
Copy link
Collaborator

@grothem grothem commented Sep 5, 2024

General Changes

  • Adds in new EtherFi market, see proposal here
  • Removes tabs and adds all markets to the market selector

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

Copy link

height bot commented Sep 5, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

github-actions bot commented Sep 5, 2024

Copy link

github-actions bot commented Sep 5, 2024

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 544.58 KB (🟢 -327 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 65.41 KB (🟢 -328 B) 609.98 KB
/404 2.54 KB (🟢 -17 B) 547.11 KB
/500 2.98 KB (🟢 -17 B) 547.55 KB
/bridge 35.9 KB (🟢 -16 B) 580.48 KB
/faucet 15.1 KB (🟢 -16 B) 559.68 KB
/governance 84.17 KB (🟢 -17 B) 628.75 KB
/governance/ipfs-preview 97.58 KB (🟢 -18 B) 642.16 KB
/governance/v3/proposal 124.15 KB (🟢 -17 B) 668.72 KB
/history 23.79 KB (🟢 -16 B) 568.37 KB
/markets 27.04 KB (🟢 -458 B) 571.61 KB
/reserve-overview 19.76 KB (🟢 -25 B) 564.34 KB
/staking 21.98 KB (🟢 -15 B) 566.55 KB
/v3-migration 29.83 KB (🟢 -16 B) 574.41 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@grothem grothem changed the title feat: etherfi market feat: etherfi market [skip cypress] Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

Copy link

github-actions bot commented Sep 6, 2024

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 544.58 KB (🟢 -327 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 65.41 KB (🟢 -328 B) 609.98 KB
/404 2.54 KB (🟢 -17 B) 547.11 KB
/500 2.98 KB (🟢 -17 B) 547.55 KB
/bridge 35.9 KB (🟢 -16 B) 580.48 KB
/faucet 15.1 KB (🟢 -16 B) 559.68 KB
/governance 84.17 KB (🟢 -17 B) 628.75 KB
/governance/ipfs-preview 97.58 KB (🟢 -18 B) 642.16 KB
/governance/v3/proposal 124.15 KB (🟢 -17 B) 668.72 KB
/history 23.79 KB (🟢 -16 B) 568.37 KB
/markets 27.04 KB (🟢 -458 B) 571.61 KB
/reserve-overview 19.76 KB (🟢 -25 B) 564.34 KB
/staking 21.98 KB (🟢 -15 B) 566.55 KB
/v3-migration 29.83 KB (🟢 -16 B) 574.41 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@foodaka foodaka merged commit df8a2c7 into main Sep 9, 2024
16 of 19 checks passed
@foodaka foodaka deleted the feat/etherfi-market branch September 9, 2024 15:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants