Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code optimizations #31

Merged
merged 8 commits into from Nov 26, 2017
Merged

Code optimizations #31

merged 8 commits into from Nov 26, 2017

Conversation

deepbrook
Copy link
Contributor

I have removed the str() conversion of the URLBuilder class, since those are already strings (I will have to see what python2.7 has to say about this, but it should hold true there as well).

Also, I renamed RantsResponse to MultiRantsResponse, since this caused me quite some confusion, since the original name is quite close to RantResponse. Therefore, I prefixed it with Multi for better clarification and readability.

Let me know what you think!

@coveralls
Copy link

coveralls commented Nov 23, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 9a80efa on nlsdfnbch:code-optimizations into c7b425f on aayush26:master.

@aayush26
Copy link
Owner

Your last PR is pushed to mainline and resulted in merge conflict. Take your time to resolve it.

@coveralls
Copy link

coveralls commented Nov 23, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 23b1287 on nlsdfnbch:code-optimizations into 9ec91cc on aayush26:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 23b1287 on nlsdfnbch:code-optimizations into 9ec91cc on aayush26:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 23b1287 on nlsdfnbch:code-optimizations into 9ec91cc on aayush26:master.

@coveralls
Copy link

coveralls commented Nov 26, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 34490f5 on nlsdfnbch:code-optimizations into 9ec91cc on aayush26:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 34490f5 on nlsdfnbch:code-optimizations into 9ec91cc on aayush26:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 34490f5 on nlsdfnbch:code-optimizations into 9ec91cc on aayush26:master.

@aayush26 aayush26 merged commit 5543f68 into aayush26:master Nov 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
pirant
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants