Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stages and deploy support #32

Closed
wants to merge 18 commits into from
Closed

Stages and deploy support #32

wants to merge 18 commits into from

Conversation

deepbrook
Copy link
Contributor

As mentioned in #30, the repo could do with some automated building.

I have add this support to the .travis.yml file. I have also added the us of build stages, which makes use of concurrent execution of jobs, which may help improve the speed of CI checks.

the Deploy stage executes only for python 3.6, and creates a bdsit_wheel, which I believe to be universally installable. Correct me if I'm wrong here, I'm not well read on the differences of the distributions.

In order to avoid building and pushing to pypi on every push, the conditional tags: true was added - that way, it is only built if you push a tagged commit.

The password for pypi should be encrypted using the travis CLI - since I'm guessing you won't want to share your pypi password with the world ;) see here for more information about this:
https://docs.travis-ci.com/user/deployment/pypi/

Let me know what you think!

@coveralls
Copy link

coveralls commented Nov 23, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 0833678 on nlsdfnbch:stages-and-deploy-support into 9ec91cc on aayush26:master.

@coveralls
Copy link

coveralls commented Nov 23, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling b36b448 on nlsdfnbch:stages-and-deploy-support into 9ec91cc on aayush26:master.

@deepbrook
Copy link
Contributor Author

deepbrook commented Nov 23, 2017

Hm. The build matrix isn't generated correctly (there should be a separate job running for each version of python in Testing). I will have a look into this.

@deepbrook
Copy link
Contributor Author

deepbrook commented Nov 23, 2017

I've asked the good people of stackoverflow, to see what they say about this.

update: Question deleted, answer found here

@coveralls
Copy link

coveralls commented Nov 23, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 9c54c2a on nlsdfnbch:stages-and-deploy-support into 9ec91cc on aayush26:master.

@coveralls
Copy link

coveralls commented Nov 23, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 2b73563 on nlsdfnbch:stages-and-deploy-support into 9ec91cc on aayush26:master.

@deepbrook
Copy link
Contributor Author

deepbrook commented Nov 23, 2017

All fixed up. Should work now, as expected. Of course, it remains to see if the deploy process works correctly - but you'd have to test this, since it requires a tag to be pushed to the repository.

@coveralls
Copy link

coveralls commented Nov 23, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 927f775 on nlsdfnbch:stages-and-deploy-support into 9ec91cc on aayush26:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 927f775 on nlsdfnbch:stages-and-deploy-support into 9ec91cc on aayush26:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 927f775 on nlsdfnbch:stages-and-deploy-support into 9ec91cc on aayush26:master.

@coveralls
Copy link

coveralls commented Nov 23, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling b0701d8 on nlsdfnbch:stages-and-deploy-support into 9ec91cc on aayush26:master.

@coveralls
Copy link

coveralls commented Nov 23, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 015e82e on nlsdfnbch:stages-and-deploy-support into 9ec91cc on aayush26:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 015e82e on nlsdfnbch:stages-and-deploy-support into 9ec91cc on aayush26:master.

Copy link
Owner

@aayush26 aayush26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you exclude files:
handlers.py
models.py
urlbuilder.py
from this commit since its a part of the last PR. Just to avoid unnecessary merge conflicts.

@coveralls
Copy link

coveralls commented Nov 23, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 8b4eb3a on nlsdfnbch:stages-and-deploy-support into 9ec91cc on aayush26:master.

@deepbrook
Copy link
Contributor Author

deepbrook commented Nov 23, 2017

I branched this off PR #31, since I figured you'd merge that one before this.

But if you tell me how I can go about excluding them from this PR, I'll get right on it! Or do I need to submit a new PR for that to work ? That might actually be easier.

@deepbrook deepbrook closed this Nov 23, 2017
@deepbrook deepbrook deleted the stages-and-deploy-support branch November 23, 2017 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants