Cleanups and speedups for T::P and T::P::Grid construction #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of trying to keep T::P's @.indices up to date with changes to $.current-grid, just let $.current-grid handle the indices method itself.
Mostly just readability improvements and very minor simplification.
Rather than iterating over @indices to build @grid, make use of xx instead since we're just filling all cells with an identical constant. This is many times faster, enough to make .new about 2x faster overall for a full-screened terminal on my laptop. The run time for Grid.new is now dominated by the time to build @indices.
The grid indices are not needed in many use cases, so initialize them lazily to make the common/base cases faster.
Now that the current-grid is handling .indices, the attribute declaration isn't needed anymore.
|
Cheers, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5 commits (plus a merge) that clean up and speed up construction of T::P and T::P::Grid.
At this point the major slowdown at initial startup is loading T::P itself, because of the remaining 'no precompilation' infection from OO::Monitors; discussing that separately with jnthn.