fix #78 (ImportError: cannot import name make_admonition in Sphinx 1.6)

[lsaffre]

This fixes #78 for me.

[lsaffre]

Hi Ahmet, what do you think about my pull request? Did you see it at all?

[abakan-zz]

Where can I find Sphinx 1.6? I didn't see it in usual places.

[abakan-zz]

Above should be like

try:
    from sphinx.util.compat import make_admonition		
except ImportError:
    from docutils.parsers.rst.directives.admonitions import BaseAdmonition as make_admonition

so that this still works with older versions of Sphinx.

[abakan-zz]

These extra lines needs to be removed.

[lsaffre]

@abakan, thanks for your explanations. I adapted my PR accordingly. I see that Travis build is still failing, but I have the impression that these failures are not caused by my changes (are they?)

[abakan-zz]

I noticed one unrelated line was deleted with the recent change. That might be causing it.

…

On Sun, Mar 12, 2017, 9:05 PM Luc Saffre ***@***.***> wrote: @abakan <https://github.com/abakan>, thanks for your explanations. I adapted my PR accordingly. I see that Travis build is still failing, but I have the impression that these failures are not caused by my changes (are they?) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#79 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMWGenfZlBJ_TL6cTlX6gDp2tt8VS6Cks5rlMBzgaJpZM4L3bMp> .

[lsaffre]

Oops, you are right. I saw that it was not being used in that module, which was of course a naive assumption. I now restored that line.

[timcera]

Thanks for this fix. Solved my problem.

[rayalan]

Still works with Sphinx 1.6.5 / Python 3.6. Would be great to see this integrated into a release.

[rayalan]

Note that this fix causes the .. update directive to no longer print the title because of the way docutil handles the BaseAdmonition class. Here's a partial patch that restores similar functionality (slight change to the formatting, doesn't do date verification any more)

class UpdateDirective(BaseAdmonition):
    required_arguments = 1
    node_class = UpdateNode

    def run(self):
        date_arg = self.arguments[0] if self.arguments else ''
        self.arguments = [_('Updated on ' + date_arg), ]
        # The following line is needed to trick the BaseAdmonition class into thinking we have a title.
        # There almost certainly has to be a better way, but I don't see it naturally from the docutils source    
        self.node_class = nodes.admonition
        ad = super(UpdateDirective, self).run()  # For Python3, it is run(), not run(self)
        del self.node_class  # Undo our tricksy hack from a few lines ago
        return ad

[nabobalis]

This has now been merged into here.
Thank you for the PR!