enable 255 cell header with table binding #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add column_name char 255 to table fieldcat - this is used as table name and cell value link cell to table and fieldcat
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
|
For information, many lines are changed, it's difficult to concentrate on the lines which only concern the fix. It would be better to provide two distinct PRs, one for the fix and one for the pretty printer. Thanks. |
|
Thanks a lot, I'll review it this week-end (unless Andrea takes it). |
|
I created a branch in the demos to make ZDEMO_EXCEL47 use your feature, but I can't make it work, the generated XLSX file is corrupted. Could you check what's going on? |
|
there was an issue with the total function - it's fixed now |
|
@bigld thanks for this, was just about to figure this out myself but figured I would search in case someone else was working on it. :D |
This was referenced Aug 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #764
Closes #726
related to #970