Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandraros/255 header #13

Merged
merged 3 commits into from
Aug 11, 2022
Merged

Sandraros/255 header #13

merged 3 commits into from
Aug 11, 2022

Conversation

sandraros
Copy link
Collaborator

@sandraros sandraros commented Aug 7, 2022

ZDEMO_EXCEL47 updated to demonstrate enhancement abap2xlsx/abap2xlsx#1051 for table headers with more than 40 characters.

Copy link
Member

@AndreaBorgia-Abo AndreaBorgia-Abo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how I see the generated output with Excel 2019:
EXCEL_yPuwQnPgGK
Other than the formula error, possibly language or version dependent, the file is opened successfully.
Incidentally, I had a git pull error on the demos that matches the linter warning; in my case, it turned out that my abap2xlsx installation was a couple of commits behind upstream and bringing it up to date fixed the problem: could it be something similar for the linter? @larshp
IOW, this should not happen again without any changes, right?

@sandraros
Copy link
Collaborator Author

sandraros commented Aug 11, 2022

Concerning the formula error with Excel 2019, it works with Excel 365, so I guess we should change the title of the demo program that it works only from Excel 365/Excel 2021 as confirmed by this Microsoft article. Added a commit with new program title: abap2xlsx Demo: Table Calculated Columns (from Excel 365 or 2021)):
image

Probably it would be better to use another program to demonstrate table headers, compatible with all Excel versions, and keep that one specific to only Calculated Columns, without demonstrating table headers, and compatible with only Excel 365/Excel 2021.

Concerning the lint failure, that happened minutes after merging the new field column_name in abap2xlsx repository, I imagined that happened because the merge was too much recent and the lint was reading the old commit, so I ran again the lint, and there was no more error.

@AndreaBorgia-Abo
Copy link
Member

AndreaBorgia-Abo commented Aug 11, 2022

Thought so, thanks for the confirmation on the linter issue.
Also, fully agree that demos should be split according to Excel version, when necessary.
Let's merge this one and deal with the rest as need arises.
EDIT: I don't have write access, this is weird.

@larshp
Copy link
Member

larshp commented Aug 11, 2022

@AndreaBorgia-Abo try again, I've invited you with write access

@AndreaBorgia-Abo AndreaBorgia-Abo merged commit 096ab05 into main Aug 11, 2022
@AndreaBorgia-Abo AndreaBorgia-Abo deleted the sandraros/255-header branch August 11, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants