Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 761 cell value " x0041 " rendered as "a" #762

Merged
merged 8 commits into from
Jun 21, 2021
Merged

Fix 761 cell value " x0041 " rendered as "a" #762

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9b6f697
Merge pull request #1 from sapmentors/master
sandraros Feb 11, 2021
9151f42
Merge pull request #3 from sapmentors/master
sandraros Feb 21, 2021
10dccc4
Merge pull request #4 from sapmentors/master
sandraros Feb 27, 2021
ce29fde
Merge pull request #5 from sapmentors/master
sandraros Mar 20, 2021
3c17df9
Merge branch 'sapmentors:master' into master
sandraros May 21, 2021
168a324
Merge branch 'sapmentors:master' into master
sandraros May 28, 2021
c7ef435
Merge branch 'sapmentors:master' into master
sandraros Jun 17, 2021
a78b601
Fix #761
Jun 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/zcl_excel_worksheet.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5019,6 +5019,17 @@ CLASS zcl_excel_worksheet IMPLEMENTATION.
me->hyperlinks->add( ip_hyperlink ).
ENDIF.

IF lv_value CS '_x'.
" Issue #761 value "_x0041_" rendered as "A".
" "_x...._", where "." is 0-9 a-f or A-F (case insensitive), is an internal value in sharedStrings.xml
" that Excel uses to store special characters, it's interpreted like Unicode character U+....
" for instance "_x0041_" is U+0041 which is "A".
" To not interpret such text, the first underscore is replaced with "_x005f_".
" The value "_x0041_" is to be stored internally "_x005f_x0041_" so that it's rendered like "_x0041_".
" Note that REGEX is time consuming, it's why "CS" is used above to improve the performance.
REPLACE ALL OCCURRENCES OF REGEX '_(x[0-9a-fA-F]{4}_)' IN lv_value WITH '_x005f_$1' RESPECTING CASE.
ENDIF.

* Begin of change issue #152 - don't touch exisiting style if only value is passed
* Read table moved up, so that current style may be evaluated
* lv_column = zcl_excel_common=>convert_column2int( ip_column ).
Expand Down