fix #844 to remove all macros

[sandraros]

fix #844 to remove all macros

[AndreaBorgia-Abo]

Other than a few minor issues with mixed-case, this is good.
The "color" flag issue was already present: as long as we preserve the (possibly broken) logic it shouldln't matter.

[larshp]

in abaplint.json, suggest changing

    "avoid_use": {
      "define": false,

to

    "avoid_use": {
      "define": true,

that way all future pull request will be rejected if they contain macros/define

[sandraros]

I did the changes you suggested. Could you review again? Thanks!
NB: I probably should not have clicked "resolve conversation" for all your suggestions, and left it up to you. It's just that I'm discovering the process so not sure of what I'm doing. Note that you can also "suggest specific changes to lines of code, which the author can apply directly", maybe that will help make the review and corrections smoother.

[sandraros]

Two more things that I just saw and fixed:

1. A bug I introduced, that I could reproduce with this code in case 1 (borders were shown):

   REPORT.
   DATA: gc_save_file_name TYPE string VALUE 'test.xlsx'.
   INCLUDE zdemo_excel_outputopt_incl.
   START-OF-SELECTION.
     TRY.
         DATA(lo_excel) = NEW zcl_excel( ).
         DATA(lo_worksheet) = lo_excel->get_active_worksheet( ).
         lo_worksheet->set_cell( ip_column = 'B' ip_row = 2 ip_value = CONV decfloat16( 1 ) ).
         " 1) cell should have no border
         lo_worksheet->change_cell_style(
               ip_column             = 'B'
               ip_row                = 2
               ip_borders_allborders = VALUE #( border_style = zcl_excel_style_border=>c_border_thick
                                                border_color = VALUE #( rgb = zcl_excel_style_color=>c_darkred ) )
               ip_xborders_allborders = VALUE #( border_style = abap_false
                                                 border_color = VALUE #( rgb = abap_false ) )
               ip_xborders = VALUE #( allborders = VALUE #( border_style = abap_true
                                                            border_color = VALUE #( rgb = abap_true ) ) ) ).
         " 2) cell should have borders
         lo_worksheet->change_cell_style(
               ip_column             = 'D'
               ip_row                = 2
               ip_borders_allborders = VALUE #( border_style = zcl_excel_style_border=>c_border_thick
                                                border_color = VALUE #( rgb = zcl_excel_style_color=>c_darkred ) )
               ip_xborders_allborders = VALUE #( border_style = abap_true
                                                 border_color = VALUE #( rgb = abap_true ) ) ).
         " 3) cell should have borders
         lo_worksheet->change_cell_style(
               ip_column             = 'F'
               ip_row                = 2
               ip_borders_allborders = VALUE #( border_style = zcl_excel_style_border=>c_border_thick
                                                border_color = VALUE #( rgb = zcl_excel_style_color=>c_darkred ) ) ).
         lcl_output=>output( cl_excel = lo_excel ).
       CATCH cx_root INTO DATA(lx_root).
         MESSAGE lx_root TYPE 'I' DISPLAY LIKE 'E'.
     ENDTRY.

2. I also removed the changing parameter cs_borderx from method move_supplied_borders, which was useless.

[AndreaBorgia-Abo]

Note that you can also "suggest specific changes to lines of code, which the author can apply directly", maybe that will help make the review and corrections smoother.

Ha, I didn't know that, "insert a suggestion" seems useful, I'll try to use it, thanks.

Let me check the new changes...

[AndreaBorgia-Abo]

LGTM

[AndreaBorgia-Abo]

@larshp I wanted to check which bug @sandraros introduced and then fixed but I couldn't find a way to check out a specific commit, only switching branches and tags are supported if I'm not mistaken. I did the next best thing, confirming the problem is indeed gone.

[larshp]

this part should help checking out a specific commit,

[AndreaBorgia-Abo]

Gosh, I kept looking in the menus... :D
Thanks.

[AndreaBorgia-Abo]

this part should help checking out a specific commit,

Close but no cigar: "Cannot find initial commit. Too many commits. Action not possible. "
Selection by PR works, though I'm not sure if it is any different than switching to the PR branch.