-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #844 to remove all macros #860
Conversation
fix #844 to remove all macros
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a few minor issues with mixed-case, this is good.
The "color" flag issue was already present: as long as we preserve the (possibly broken) logic it shouldln't matter.
in
to
that way all future pull request will be rejected if they contain macros/define |
I did the changes you suggested. Could you review again? Thanks! |
Two more things that I just saw and fixed:
|
Ha, I didn't know that, "insert a suggestion" seems useful, I'll try to use it, thanks. Let me check the new changes... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@larshp I wanted to check which bug @sandraros introduced and then fixed but I couldn't find a way to check out a specific commit, only switching branches and tags are supported if I'm not mistaken. I did the next best thing, confirming the problem is indeed gone. |
Gosh, I kept looking in the menus... :D |
Close but no cigar: "Cannot find initial commit. Too many commits. Action not possible. " |
fix #844 to remove all macros