Sandraros/check demo regressions #902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) change many demo programs to make lcl_excel_generator inherit from zcl_demo_excel_generator instead of implementing zif_demo_excel_generator. 2) replace sy-datum with zcl_demo_excel_generator=>get_date_now( ), and sy-uzeit with zcl_demo_excel_generator=>get_time_now( ), so that comparison can operate on same fixed data
Co-authored-by: Abo <andrea@borgia.bo.it>
|
I'll do the full review over the coming days, stay tuned. |
|
Review time... |
|
@AndreaBorgia-Abo I forgot to say that I was working on a second simplest version to check demo regressions, whose advantage is to not change the demo programs. It's simply based on the Excel files created on the frontend by program |
|
Sheesh, ended up using this PR as a guinea pig for a possible abapGit bug ... I'll check the newer version first, then! |
AndreaBorgia-Abo
requested changes
Jan 3, 2022
|
Closing in favor of other PR #940 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #894