Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abap git master #4414

Closed
wants to merge 5 commits into from
Closed

Abap git master #4414

wants to merge 5 commits into from

Conversation

codingkrabbe
Copy link

No description provided.

JustACasual and others added 5 commits December 28, 2020 13:21
* zif_abapgit_html, remove uses of char1 (#4351)

* Implement jump for CUS0 (#4353)

* Implement jump for CUS1 (#4354)

* use cl_abap_hmac for calculating md5 (#4355)

* LOG: add basic unit tests, change types (#4352)

closes #4259

* unit testing test (#4345)

* update deps

* update deps

* remove CHAR01 usages

* update deps

* update deps

* update deps

* all unit tests in syntax now running!

* update deps

* update deps

* update deps

* enable additional exception unit tests

* zcl_abapgit_string_map running

* upd

* login manager running

* update deps, add progress clas

* upd

* update deps

* fix whitespace

* update deps

* upd

* update deps

* update deps

* update deps

* use cl_abap newline

* upd

* run more

* sort

* update deps

* add intf

* update deps

* upd

* add zcl_abapgit_exit

* some xml interfaces

* zcl_abapgit_version running

* Checkout commit: additional user interface (#4120) (#4349)

* Set branch name with commit

* Can't stage when commit is checked out

* Add missing variable

* Remove passing a parameter, since set relies on IS SUPPLIED

* Undo last commit

* Intelligent create branch when commit is checked o

ut

* lint

* Fix cancel buttons (missing commit)

* Code review

* Remove unused variables

* Add extra line

* Remove unused variable

* Add back new branch pop-up. Considers tag.

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Fix pull errors related to files deleted remotely (#4338)

* Fix pull errors related to files deleted remotely

Improve #4281 by moving "ignore logic" to `filter_files_to_deserialize`

* Added unit test

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* 1.104.0 (#4356)

* 1.104.0

* v1.104.0

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Fabian Lupa <fabian@lupa.dev>
Co-authored-by: Eduardo Ferrari Copat <ecopat@gmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
FIELD-SYMBOLS:
<ls_tpool> LIKE LINE OF lt_tpool_i18n,
<lxe_object> TYPE lxe_colob,
<ls_lxe_text_item> TYPE zcl_abapgit_object_prog=>ty_lxe_i18n.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference to current class can be omitted: "ZCL_ABAPGIT_OBJECT_PROG=>"

Suggest following fix,

Suggested change
<ls_lxe_text_item> TYPE zcl_abapgit_object_prog=>ty_lxe_i18n.
<ls_lxe_text_item> TYPE ty_lxe_i18n.

Copy link
Member

@larshp larshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@codingkrabbe
Copy link
Author

hey,
sorry for the confusion, I did not plan to merge this already and misclicked.
Please ignore this, didn't want to make a mess.
regards codingkrabbe

@JustACasual JustACasual deleted the abapGit-master branch January 15, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants