Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "branch overview" class/interface #5503

Merged
merged 6 commits into from
May 1, 2022
Merged

Conversation

mbtools
Copy link
Member

@mbtools mbtools commented Apr 29, 2022

Removing zcl/if_abapgit_branch_overview which are not used by AG anymore

Closes #5502

@mbtools mbtools added the refactoring Change code without altering functionality label Apr 29, 2022
@mbtools mbtools marked this pull request as draft April 29, 2022 13:33
@larshp
Copy link
Member

larshp commented Apr 29, 2022

so, according to the cross check, looks like this will break https://github.com/abapGit/background_modes/

I did not look into any details...

@mbtools
Copy link
Member Author

mbtools commented Apr 29, 2022

small change but don't have write access to https://github.com/abapGit/background_modes/

@larshp
Copy link
Member

larshp commented Apr 29, 2022

@mbtools try again, open a PR there, rerun the cross check here, and it will tell if the branch is good

mbtools added a commit to abapGit/background_modes that referenced this pull request Apr 29, 2022
Adjust to removal of `zcl_abapgit_branch_overview` in abapGit abapGit/abapGit#5503
mbtools added a commit to abapGit/background_modes that referenced this pull request Apr 29, 2022
Adjust to removal of `zcl_abapgit_branch_overview` in abapGit abapGit/abapGit#5503
mbtools and others added 2 commits April 29, 2022 16:49
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@mbtools mbtools marked this pull request as ready for review April 29, 2022 15:19
@mbtools mbtools merged commit 588fb00 into main May 1, 2022
@mbtools mbtools deleted the mbtools/del_branch_ovr branch May 1, 2022 10:33
@mbtools mbtools mentioned this pull request Feb 8, 2023
mbtools added a commit that referenced this pull request Feb 25, 2023
- Remove `onTagTypeChange` (usage removed in #5591)
- Remove `BranchOverview` (usage removed in #5503)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Change code without altering functionality
Development

Successfully merging this pull request may close these issues.

Delete zcl/if_abapgit_branch_overview
2 participants