Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AQSG support #6161

Merged
merged 3 commits into from
Mar 23, 2023
Merged

AQSG support #6161

merged 3 commits into from
Mar 23, 2023

Conversation

larshp
Copy link
Member

@larshp larshp commented Mar 22, 2023 •
edited
Loading

test repository = https://github.com/abapGit-tests/AQSG

looks like it doesnt require any rules, or has the changed by user

@larshp larshp mentioned this pull request Mar 22, 2023
Merged
@larshp larshp marked this pull request as ready for review March 22, 2023 14:43
mbtools
mbtools reviewed Mar 22, 2023
View reviewed changes
Copy link
Member

@mbtools mbtools left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS: My comments also apply to aqbg which I hadn't looked at closely.

src/objects/zcl_abapgit_object_aqsg.clas.abap Show resolved Hide resolved
mbtools
mbtools approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@mbtools mbtools left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@larshp larshp merged commit 2df96f9 into main Mar 23, 2023
@larshp larshp deleted the hvam/AQSG2203 branch March 23, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbtools mbtools mbtools approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larshp @mbtools