Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Godot CLI arguments to use --headless everywhere #113

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Fix Godot CLI arguments to use --headless everywhere #113

merged 1 commit into from
Dec 21, 2023

Conversation

Calinou
Copy link
Collaborator

@Calinou Calinou commented Jun 12, 2023

  • Use long-form --verbose and --editor for better readability.

@Calinou Calinou added the bug Something isn't working label Jun 12, 2023
@jtuchel jtuchel mentioned this pull request Jun 12, 2023
Closed
@OverloadedOrama
Copy link
Contributor

--headless doesn't exist in Godot 3.x, right? test-project seems to be a Godot 3.x project, and GODOT_VERSION is set to 3.3.4. Maybe the test project should be updated to Godot 4.x as well?

@Calinou
Copy link
Collaborator Author

Calinou commented Jun 13, 2023 •
edited
Loading

test-project seems to be a Godot 3.x project, and GODOT_VERSION is set to 3.3.4.

Ah, I didn't notice that. In any case, unknown CLI arguments are ignored, so this change is backwards-compatible.

Towfieee
Towfieee suggested changes Dec 19, 2023
View reviewed changes
.github/workflows/godot-ci.yml Outdated Show resolved Hide resolved
@Calinou
Fix Godot CLI arguments to use --headless everywhere
2d07e94 
- Use long-form `--verbose` and `--editor` for better readability.
@Calinou Calinou merged commit c1f87c9 into abarichello:master Dec 21, 2023
@Calinou Calinou deleted the fix-godot-cli-arguments branch December 21, 2023 16:43
@Calinou Calinou mentioned this pull request Dec 21, 2023
Merged
@Calinou Calinou mentioned this pull request Jan 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Towfieee Towfieee Towfieee approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows build problems
3 participants
@Calinou @OverloadedOrama @Towfieee