Exception parsing "nan"

[hurzl]

"nan" is an allowed setting for mixrampdelay in mpd.
http://www.musicpd.org/doc/protocol/ch03s02.html

MPDroid expects a Float

E/AndroidRuntime( 4474): FATAL EXCEPTION: MPDStatusMonitor
E/AndroidRuntime( 4474): Process: com.namelessdev.mpdroid, PID: 4474
E/AndroidRuntime( 4474): java.lang.NumberFormatException: Invalid float: "nan"
E/AndroidRuntime( 4474):        at java.lang.StringToReal.invalidReal(StringToReal.java:63)
E/AndroidRuntime( 4474):        at java.lang.StringToReal.parseFloat(StringToReal.java:310)
E/AndroidRuntime( 4474):        at java.lang.Float.parseFloat(Float.java:300)
E/AndroidRuntime( 4474):        at org.a0z.mpd.MPDStatus.updateStatus(MPDStatus.java:407)
E/AndroidRuntime( 4474):        at org.a0z.mpd.MPD.getStatus(MPD.java:1115)
E/AndroidRuntime( 4474):        at org.a0z.mpd.MPDStatusMonitor.run(MPDStatusMonitor.java:169)
W/ActivityManager( 2282):   Force finishing activity com.namelessdev.mpdroid/.MainMenuActivity

[abarisain]

Why are we even parsing that line ? Do we care about it ?

(All float parses should be in try/catch anyway)
Le 14 mai 2014 15:14, "hurzl" notifications@github.com a écrit :

"nan" is an allowed setting for mixrampdelay in mpd.
http://www.musicpd.org/doc/protocol/ch03s02.html

MPDroid expects a Float

E/AndroidRuntime( 4474): FATAL EXCEPTION: MPDStatusMonitor
E/AndroidRuntime( 4474): Process: com.namelessdev.mpdroid, PID: 4474
E/AndroidRuntime( 4474): java.lang.NumberFormatException: Invalid float: "nan"
E/AndroidRuntime( 4474): at java.lang.StringToReal.invalidReal(StringToReal.java:63)
E/AndroidRuntime( 4474): at java.lang.StringToReal.parseFloat(StringToReal.java:310)
E/AndroidRuntime( 4474): at java.lang.Float.parseFloat(Float.java:300)
E/AndroidRuntime( 4474): at org.a0z.mpd.MPDStatus.updateStatus(MPDStatus.java:407)
E/AndroidRuntime( 4474): at org.a0z.mpd.MPD.getStatus(MPD.java:1115)
E/AndroidRuntime( 4474): at org.a0z.mpd.MPDStatusMonitor.run(MPDStatusMonitor.java:169)
W/ActivityManager( 2282): Force finishing activity com.namelessdev.mpdroid/.MainMenuActivity

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/547
.

[hurzl]

Because we can (can't we?) ;)

[abarisain]

Well obviously we can't correctly :p

[avuton]

I'll take care of this.

[hurzl]

We could! It could be a future setting ...

[hurzl]

Btw. "xfade" doesn't appear if it is zero. So crossfade should be set to zero before getting the status

... ok that's done ... but not for the mixRamp... values

[avuton]

Crossfade /is/ reset prior to status updating.

[avuton]

Granted, mixRampDelay doesn't always show during some status updates (this will be fixed soon). Are you saying there are times that mixRampDB doesn't show on the status?

[avuton]

Also, if you edit your comment, I never get notice that you replied :)

[hurzl]

Sorry I meant that mixRampXX is not in resetValues

[avuton]

Yeah, no need to reset mixRampDB everytime, as it's in the status everytime; mixRampDelay on the other hand is fixed in another commit.