GC: remove DNS records for last server uninstall #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The uninstallation of the last server with GC role can happen after various code paths: - server-del + uninstall - direct uninstall In order to detect that the last GC is being uninstalled, the code relies on the output of server-role-find(GC, enabled). The current server is the last GC in the following cases: - EmptyResult exception - 0 result - 1 result corresponding to the current server. In all the above cases, the uninstaller must remove GC DNS records. Fixes: https://pagure.io/freeipa/issue/8758 Signed-off-by: Florence Blanc-Renaud <flo@redhat.com>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The uninstallation of the last server with GC role can
happen after various code paths:
In order to detect that the last GC is being uninstalled, the
code relies on the output of server-role-find(GC, enabled).
The current server is the last GC in the following cases:
In all the above cases, the uninstaller must remove GC DNS records.
Fixes: https://pagure.io/freeipa/issue/8758
Signed-off-by: Florence Blanc-Renaud flo@redhat.com