Skip to content

Commit

Permalink
updating test of Number type check from boolean to 0,1 (dbt-labs#58)
Browse files Browse the repository at this point in the history
* updating test of Number type check from boolean to 0,1

* update changelog

* removing draft contributing file
  • Loading branch information
McKnight-42 committed Jan 5, 2022
1 parent 76217f6 commit 6bde192
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
## dbt-redshift 1.0.0 (Release TBD)
## dbt-redshift 1.0.1 (TBD)

### Fixes
- Fix test related to preventing coercion of boolean values (True,False) to numeric values (0,1) in query results ([#58](https://github.com/dbt-labs/dbt-redshift/blob/1.0.latest/CHANGELOG.md))

## dbt-redshift 1.0.0 (December 3, 2021)

## dbt-redshift 1.0.0rc2 (November 24, 2021)

Expand Down
2 changes: 1 addition & 1 deletion tests/unit/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ def _get_tester_for(self, column_type):
return agate.TimeDelta()

for instance in agate_helper.DEFAULT_TYPE_TESTER._possible_types:
if type(instance) is column_type:
if isinstance(instance, column_type):
return instance

raise ValueError(f'no tester for {column_type}')
Expand Down

0 comments on commit 6bde192

Please sign in to comment.