Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating test of Number type check from boolean to 0,1 #58

Merged
merged 5 commits into from Jan 5, 2022

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Jan 4, 2022

resolves comment made in #dbt-labs/dbt-bigquery#93 (comment)
-->

Description

responding to comment about test failure from other adapter plugin also appearing in redshift repo

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-redshift next" section.

@cla-bot cla-bot bot added the cla:yes label Jan 4, 2022
@McKnight-42 McKnight-42 merged commit cf996eb into main Jan 5, 2022
@McKnight-42 McKnight-42 deleted the mcknight/Number_type_fix branch January 5, 2022 15:14
@McKnight-42 McKnight-42 mentioned this pull request Mar 24, 2022
4 tasks
McKnight-42 added a commit that referenced this pull request Mar 25, 2022
* backporting #80 to unstick releases for adapters

* updating dev_requirements and commenting out lines in main.yaml

* adding backport of pr#58 to get rid of testing error based on pr #4512 in dbt-core

* uncommenting to see if we can make pointers of local install and tox install the same

* testing if tox change is all thats needed

* tests failed proving the addition is needed as backport #58

* trying out removal of dbt-core-ref install

* remove white-space

* remove whitespace

* remove trailing whitespace on main.yml
abbywh pushed a commit to abbywh/dbt-redshift that referenced this pull request Oct 11, 2023
* updating test of Number type check from boolean to 0,1

* update changelog

* removing draft contributing file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants