Skip to content
This repository has been archived by the owner on Aug 13, 2020. It is now read-only.

Add a demo page at: http://abcnews.github.io/jquery-avoidOrphans/ #1

Merged
merged 2 commits into from
Feb 5, 2015

Conversation

peterchappell
Copy link
Contributor

Also link to it in the readme and make the updating of it part of the build grunt task.

…nk to it in the readme. Make the updating of it part of the build grunt task.
@peterchappell peterchappell assigned AshKyd and unassigned AshKyd Feb 5, 2015
@peterchappell
Copy link
Contributor Author

The demo page might want some design love (depending on whether we want to brand these). Not sure if things like this need to be Pull Requests but reckon they probably should be.

cc. @drzax @AshKyd @colingourlay @blakebutcher

@AshKyd
Copy link
Member

AshKyd commented Feb 5, 2015

Looks good.

@@ -4,6 +4,7 @@
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<title>avoid-orphans</title>
<link rel="stylesheet" href="styles/demo.css">
<script src="http://cdnjs.cloudflare.com/ajax/libs/jquery/1.11.1/jquery.min.js"></script>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross protocol security issues :(

Try: <script src="//cdnjs.cloudflare.com/ajax/libs/jquery/1.11.1/jquery.min.js"></script>

@peterchappell peterchappell merged commit 31fc015 into master Feb 5, 2015
@peterchappell peterchappell deleted the demo-page branch February 5, 2015 04:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants