Refactor spec.go to remove UnmarshalYAML boilerplate #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we could only iterate over a hardcoded YAML list of values. This PR adds the `values_from: 'some_cel_expression'` field to programmatically compute a list of strings to iterate over. We may want to add caching of compiled CEL programs in the future to avoid paying a few milliseconds per compilation. We don't currently have any use cases where a for_each action will run often enough for that to matter, but it's conceivable that the latency would be noticeable for deeply-nested for_each actions. Still to do: write docs and examples
Before this, each UnmarshalYAML function was a copy-pasted block of 20-ish lines of boilerplate. With this change, each UnmarshalYAML function turns into a one-liner which calls unmarshalPlain. This requires a somewhat regrettable amount of reflection code, but it's arguably no more confusing than what was there before, while having the benefit of being more concise and DRY. Fixes #30.
sethvargo
previously approved these changes
Aug 22, 2023
yolocs
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, each UnmarshalYAML function was a copy-pasted block of 20-ish lines of boilerplate. With this change, each UnmarshalYAML function turns into a one-liner which calls unmarshalPlain.
This requires a somewhat regrettable amount of reflection code, but it's arguably no more confusing than what was there before, while having the benefit of being more concise and DRY.
Fixes #30.
I'm attempting to use stacked PRs here; I intend to switch the base branch of this PR to
mainonce thedrevell/for-each-values-frombranch is merged.