feat: add prober code #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sailorlqh
requested review from
verbanicm,
lock14,
yolocs and
capri-xiyue
and removed request for
verbanicm and
lock14
capri-xiyue
reviewed
Jul 26, 2023
capri-xiyue
reviewed
Jul 26, 2023
capri-xiyue
reviewed
Jul 26, 2023
capri-xiyue
reviewed
Jul 26, 2023
|
/Hold until PR#159 for refactoring the common code is merged. |
yolocs
requested changes
Jul 26, 2023
sailorlqh
force-pushed
the
sailorlqh/add_prober_go
branch
3 times, most recently
from
af3dc06
to
aa510f8
Compare
yolocs
reviewed
Jul 28, 2023
capri-xiyue
requested changes
Jul 28, 2023
sailorlqh
force-pushed
the
sailorlqh/add_prober_go
branch
2 times, most recently
from
94a66dc
to
a913ad3
Compare
capri-xiyue
reviewed
Jul 28, 2023
capri-xiyue
reviewed
Jul 28, 2023
yolocs
reviewed
Jul 28, 2023
yolocs
previously approved these changes
Jul 28, 2023
Yes, I have tested using current pmap-dev project. |
capri-xiyue
reviewed
Jul 28, 2023
capri-xiyue
approved these changes
Jul 28, 2023
sailorlqh
force-pushed
the
sailorlqh/add_prober_go
branch
from
596befb
to
5884d0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add go code for prober, as part of the fix of #157.
Probing for policy service, other resource setup like cloud run job, and goreleaser update will in following PRs.