Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add subscope and validate if subscope is in correct format. #176

Merged
merged 12 commits into from
Aug 9, 2023
Merged

feat: add subscope and validate if subscope is in correct format. #176

merged 12 commits into from
Aug 9, 2023

Conversation

sailorlqh
Copy link
Contributor

fix: #164

@sailorlqh sailorlqh requested a review from a team as a code owner August 7, 2023 23:51
capri-xiyue
capri-xiyue requested changes Aug 8, 2023
View reviewed changes
apis/v1alpha1/resource_mapping.pb.go Outdated Show resolved Hide resolved
apis/v1alpha1/resource_mapping.pb.go Outdated Show resolved Hide resolved
apis/v1alpha1/validation.go Outdated Show resolved Hide resolved
apis/v1alpha1/validation.go Outdated Show resolved Hide resolved
apis/v1alpha1/validation.go Outdated Show resolved Hide resolved
apis/v1alpha1/validation_test.go Show resolved Hide resolved
@sailorlqh sailorlqh force-pushed the sailorlqh/add_and_validate_subscope branch from 27d42ab to 916feca Compare August 8, 2023 22:29
@sailorlqh sailorlqh force-pushed the sailorlqh/add_and_validate_subscope branch from 916feca to 987666f Compare August 8, 2023 22:31
yolocs
yolocs requested changes Aug 8, 2023
View reviewed changes
protos/v1alpha1/resource_mapping.proto Show resolved Hide resolved
protos/v1alpha1/resource_mapping.proto Outdated Show resolved Hide resolved
protos/v1alpha1/resource_mapping.proto Outdated Show resolved Hide resolved
protos/v1alpha1/resource_mapping.proto Show resolved Hide resolved
apis/v1alpha1/validation.go Outdated Show resolved Hide resolved
apis/v1alpha1/validation.go Outdated Show resolved Hide resolved
apis/v1alpha1/validation.go Outdated Show resolved Hide resolved
apis/v1alpha1/validation.go Outdated Show resolved Hide resolved
@sailorlqh sailorlqh force-pushed the sailorlqh/add_and_validate_subscope branch from 553d308 to a7847c6 Compare August 9, 2023 00:13
yolocs
yolocs requested changes Aug 9, 2023
View reviewed changes
apis/v1alpha1/validation.go Outdated Show resolved Hide resolved
apis/v1alpha1/validation.go Outdated Show resolved Hide resolved
apis/v1alpha1/validation.go Outdated Show resolved Hide resolved
apis/v1alpha1/validation.go Outdated Show resolved Hide resolved
apis/v1alpha1/validation_test.go Outdated Show resolved Hide resolved
apis/v1alpha1/validation.go Outdated Show resolved Hide resolved
protos/v1alpha1/resource_mapping.proto Outdated Show resolved Hide resolved
capri-xiyue
capri-xiyue requested changes Aug 9, 2023
View reviewed changes
apis/v1alpha1/validation.go Outdated Show resolved Hide resolved
apis/v1alpha1/validation.go Outdated Show resolved Hide resolved
apis/v1alpha1/validation.go Show resolved Hide resolved
@sailorlqh sailorlqh requested a review from yolocs August 9, 2023 19:42
yolocs
yolocs previously approved these changes Aug 9, 2023
View reviewed changes
@sailorlqh sailorlqh force-pushed the sailorlqh/add_and_validate_subscope branch from 519e7e1 to a362c68 Compare August 9, 2023 20:42
@sailorlqh sailorlqh merged commit 6d5fe15 into main Aug 9, 2023
2 checks passed
@sailorlqh sailorlqh deleted the sailorlqh/add_and_validate_subscope branch August 9, 2023 22:00
@abcxyz abcxyz deleted a comment from capri-xiyue Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capri-xiyue capri-xiyue capri-xiyue approved these changes

@yolocs yolocs yolocs left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for mapping subresource.
3 participants
@sailorlqh @yolocs @capri-xiyue