fix(browser): fix hidden errors when the parent group already had suc…

…cess
abe33 · Jul 14, 2013 · edfbc73 · edfbc73
1 parent eec62aa
commit edfbc73
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 9 deletions.
diff --git a/lib/browser_reporter.js b/lib/browser_reporter.js
diff --git a/src/browser_reporter.coffee b/src/browser_reporter.coffee
@@ -1,5 +1,11 @@
 utils = spectacular.utils
 
+ancestors = (node, block) ->
+  parent = node.parentNode
+
+  if hasClass parent, 'example-group'
+    block.call this, parent
+    ancestors parent, block
 
 wrapNode = (node) ->
   if node.length? then node else [node]
@@ -189,11 +195,11 @@ class spectacular.BrowserReporter
       @formatProgressExample example
 
   formatDocumentationExample: (example) ->
-    ancestors = example.ancestors
-    ancestors.pop()
+    elders = example.ancestors
+    elders.pop()
 
     reversed = []
-    reversed.unshift a for a in ancestors
+    reversed.unshift a for a in elders
 
     node = @examplesContainer
     n = 0
@@ -251,13 +257,23 @@ class spectacular.BrowserReporter
         }
       """
 
+
     ex.onclick = -> toggleClass ex, 'closed'
+
     node.appendChild ex
+    if example.failed
+      ancestors ex, (node) ->
+        if hasClass node, 'success'
+          removeClass node, 'success'
+          addClass node, 'failure'
+
     pres = ex.querySelectorAll('pre:not([id])')
     Array::forEach.call pres, (node) -> fixNodeHeight node
     addClass ex, 'closed'
     setTimeout (-> addClass ex, 'animate'), 100
 
+
+
   formatProgressExample: (example) ->
     id = @examples.length
     ex = document.createElement 'article'