Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor issues #5

Closed
tdjastrzebski opened this issue Apr 3, 2016 · 8 comments
Closed

minor issues #5

tdjastrzebski opened this issue Apr 3, 2016 · 8 comments

Comments

@tdjastrzebski
Copy link

Hi, I just tried to use your service component.

Three issues I discovered so far:

  1. Swagger file has no content if WebGet/WebInvoke attributes are placed on the implementing methods, rather than interface. I know it is not recommended, but it is permissible.
  2. Code fails with "null reference exception" when WebInvoke attrib has no Method argument - POST is the default value.
  3. Even swagger content is internally properly built no file gets returned. GetSwaggerFile() method completes but browser gets stacked displaying "fetching resource list: http://localhost:63780/api-docs/swagger.json". In my case the content is just ~ 9k.

Best regards,

Tomasz

@abelsilva
Copy link
Owner

Hi Tomasz

First two issues are easily fixable.

Last one I didn't understand, on what conditions does that happen? 'no file gets returned'

Thanks
Abel

@abelsilva
Copy link
Owner

Hi Tomasz

check latest version 0.1.3 with fixes and let me know about your third issue

thanks
Abel

@tdjastrzebski
Copy link
Author

Hi Abel,

the two issues appear to be fixed.

For the third one – screenshots and IE 11 F12 network capture file attached.

Basically, the http request does not go beyond sw1.png screenshot.

Is it “missing underscore-min.map”?

Thanks,

Tomasz

From: Abel Silva [mailto:notifications@github.com]
Sent: Monday, April 4, 2016 8:37 PM
To: abelsilva/swaggerwcf swaggerwcf@noreply.github.com
Cc: tdjastrzebski tdjastrzebski@wp.pl
Subject: Re: [abelsilva/swaggerwcf] minor issues (#5)

Hi Tomasz

check latest version 0.1.3 with fixes and let me know about your third issue

thanks
Abel


You are receiving this because you authored the thread.
Reply to this email directly or #5 (comment) view it on GitHub https://github.com/notifications/beacon/AG_GXZ1gmxgTHCvHSR9-A8OXFrUlXSivks5p0VpmgaJpZM4H-r4x.gif

@abelsilva
Copy link
Owner

Hi Tomasz

attached files not included...

@tdjastrzebski
Copy link
Author

Hi, files attached here again.
Tomasz

sw3
sw1
sw2

NetworkData.txt

@abelsilva
Copy link
Owner

can you try opening directly with the browser the swagger.json?

http://localhost:63780/api-docs/swagger.json

@abelsilva
Copy link
Owner

the .map file may be missing, it's not important, it's a mapping for the minified js file (used when opening the js debugger on the browser)

@abelsilva
Copy link
Owner

If you can see the swagger.json, can you go to:
http://editor.swagger.io/

and do File \ Paste JSON and input the contents to check if there is any error with it?

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants