Fix bugs related to EXPIRY_DATE_NOT_DEFINED #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Y_DATE_NOT_DEFINED EXPIRY_DATE_NOT_DEFINEDなのにも関わらずエラーが吐かれるバグを修正
momomomo111
commented
Jun 27, 2023
Comment on lines
50
to
53
| if (expiryDate == FlagType.EXPIRY_DATE_INFINITE) { | ||
| reportInfiniteExpiryDateErrorIfNeeded(qualifiedName, context, element, location) | ||
| return | ||
| } |
There was a problem hiding this comment.
Prioritize giving warnings when WorkInProgress and Experiment contain EXPIRY_DATE_INFINITE.
momomomo111
changed the title
takahirom
reviewed
Jun 27, 2023
| val expiryDate = (annotationAttributes.firstOrNull { it.name == "expiryDate" } | ||
| ?.evaluate() as String?) ?: "" | ||
| if (expiryDate == FlagType.EXPIRY_DATE_INFINITE) { | ||
| reportInfiniteExpiryDateErrorIfNeeded(qualifiedName, context, element, location) | ||
| return | ||
| } | ||
| if (owner == FlagType.OWNER_NOT_DEFINED || expiryDate == FlagType.EXPIRY_DATE_NOT_DEFINED) return |
There was a problem hiding this comment.
Could you elaborate on why you use owner here? 👀
There was a problem hiding this comment.
You are right, I don't use the OWNER parameter. Thanks for pointing that out to me.🙏
不要なパラメーター判定の削除
momomomo111
changed the title
momomomo111
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue where a warning to set the deadline in the correct format was displayed even when
OWNER_DATE_NOT_DEFINED andEXPIRY_DATE_NOT_DEFINED were set.