Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs related to EXPIRY_DATE_NOT_DEFINED #31

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Fix bugs related to EXPIRY_DATE_NOT_DEFINED #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5a21d2
[fix] Fixed a bug that caused an error to be thrown even though EXPIR…
momomomo111 Jun 27, 2023
85e5479
[delete] Deletion of unnecessary parameter judgments
momomomo111 Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions flagfit-lint/src/main/java/tv/abema/flagfit/FlagTypeExpiryDateIllegalParamDetector.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ class FlagTypeExpiryDateIllegalParamDetector : Detector(), SourceCodeScanner {
reportInfiniteExpiryDateErrorIfNeeded(qualifiedName, context, element, location)
return
}
if (expiryDate == FlagType.EXPIRY_DATE_NOT_DEFINED) return
if (!isDateFormatValid(expiryDate)) {
val message = "The value of expireDate is not in the correct date format.\n" +
"Please set the expiration date in the following format: \"yyyy-mm-dd\""
Expand Down
34 changes: 34 additions & 0 deletions flagfit-lint/src/test/java/tv/abema/flagfit/FlagTypeExpiryDateIllegalParamDetectorText.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,40 @@ class FlagTypeExpiryDateIllegalParamDetectorText : LintDetectorTest() {
.expectClean()
}

@Test
fun testDeprecatedFlagTypeNoWarning() {
lint()
.files(
stabBooleanFlag,
stabFlagType,
kotlin(
"""
package foo
import tv.abema.flagfit.FlagType
import tv.abema.flagfit.annotation.BooleanFlag
import tv.abema.flagfit.FlagType.Companion.OWNER_NOT_DEFINED
import tv.abema.flagfit.FlagType.Companion.EXPIRY_DATE_NOT_DEFINED

interface Example {
@BooleanFlag(
key = "new-awesome-feature",
defaultValue = false
)
@FlagType.Ops(
owner = OWNER_NOT_DEFINED,
expiryDate = EXPIRY_DATE_NOT_DEFINED,
)
fun awesomeOpsFeatureEnabled(): Boolean
}
""".trimIndent()
)
)
.issues(*issues.toTypedArray())
.allowMissingSdk()
.run()
.expectClean()
}

override fun getDetector(): Detector = FlagTypeExpiryDateIllegalParamDetector()

override fun getIssues(): MutableList<Issue> {
Expand Down