You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello @sunfish-shogi, i'm about to contribute AV1 boxes, but i have a style-related doubt: the box_types.go file is getting huge and it's about to become even bigger in the future. This adds a degree of difficulty to all maintenance operations, i.e. finding boxes, adding boxes and keeping everything ordered.
In my opinion, the file should be splitted into multiple ones by using some criterion, for instance:
by single box. This would be optimal and doesn't cause any performance issue in go (see my library gomavlib) but it may be better to perform the operation in a dedicated folder, and this would break compatibility with the existing API:
box_type_btrt.go
box_type_colr.go
Regardless of the criterion, this is in my opinion a good way to improve maintainability of the library.
The text was updated successfully, but these errors were encountered:
Hello @sunfish-shogi, i'm about to contribute AV1 boxes, but i have a style-related doubt: the
box_types.go
file is getting huge and it's about to become even bigger in the future. This adds a degree of difficulty to all maintenance operations, i.e. finding boxes, adding boxes and keeping everything ordered.In my opinion, the file should be splitted into multiple ones by using some criterion, for instance:
by specification (my choice), for instance:
box_types_iso_14496_12.go
box_types_iso_14496_14.go
box_types_metadata.go
box_types_other.go
by starting letter:
box_types_a.go
box_types_b.go
by single box. This would be optimal and doesn't cause any performance issue in go (see my library gomavlib) but it may be better to perform the operation in a dedicated folder, and this would break compatibility with the existing API:
box_type_btrt.go
box_type_colr.go
Regardless of the criterion, this is in my opinion a good way to improve maintainability of the library.
The text was updated successfully, but these errors were encountered: