Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull master #34

Merged
merged 2 commits into from Jan 18, 2019
Merged

pull master #34

merged 2 commits into from Jan 18, 2019

Conversation

abennouna
Copy link
Owner

Short description of what this resolves:

Changes proposed in this pull request:

Ionic Version:

Fixes: #

also updates e2e test so that it will continue to take screenshots after mismatches and adds the popover example to avoid future regressions

references #16715 fixes #17142
@abennouna abennouna merged commit 88043d5 into abennouna:master Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants