Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 12.18.4 #55

Closed
wants to merge 4 commits into from
Closed

Node 12.18.4 #55

wants to merge 4 commits into from

Conversation

emjimadhu
Copy link

@emjimadhu emjimadhu commented Aug 25, 2020

This PR has following

Meteor 1.11.1
Node 12.18.4

you can use the Docker image from here https://hub.docker.com/repository/docker/emjimadhu/meteord

@maxfi
Copy link

maxfi commented Oct 14, 2020

@emjimadhu Now that Meteor v1.11.1 has been updated to use node to v12.18.4 maybe this can be updated in your PR? Thanks!

@emjimadhu emjimadhu changed the title Node 12.18.3 Node 12.18.4 Oct 14, 2020
@emjimadhu
Copy link
Author

@emjimadhu Now that Meteor v1.11.1 has been updated to use node to v12.18.4 maybe this can be updated in your PR? Thanks!

Done! this PR is update for Meteor 1.11.1 and Node 12.18.4 and the Docker images are also updated. Thanks

@maxfi
Copy link

maxfi commented Oct 15, 2020

Any chance we could get this merged @abernix and pushed to Docker Hub? Would be really helpful for people using https://github.com/zodern/meteor-up. Realise you're probably super busy so thanks heaps in advance! 🙏 🙏 🙏

@eugle
Copy link

eugle commented Oct 28, 2020

It feels like the author gave up

@mtwalsh
Copy link

mtwalsh commented Dec 10, 2020

Still early days in my testing but this image (zodern/meteor) seems to be working fine so far with Meteor 1.12 and it automatically uses the correct Node.js and npm versions:

https://github.com/zodern/meteor-docker

@abernix
Copy link
Owner

abernix commented Dec 30, 2020

I've published new images with Node.js 12.20.0 and Meteor 1.12.

@abernix abernix closed this Dec 30, 2020
@wvanooijen92
Copy link

@abernix Thank you! But I am a bit confused. It seems like meteor's node version is v12.18.4 for meteor v1.12 and v12.20.1 for meteor v1.12.1

$ meteor --version
Meteor 1.12

$ meteor node -v
v12.18.4
$ meteor --version
Meteor 1.12.1

$ meteor node -v
v12.20.1

With 12.20.0 I am unable to deploy. I get a "invalid ELF header" error, also described here veliovgroup/Meteor-Files#781

I may be mistaken but to be able to test v12.18.4 and 12.20.1 would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants