Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the args when init class and fix some typo. #44

Merged
merged 10 commits into from
Jan 4, 2022
Merged

Check the args when init class and fix some typo. #44

merged 10 commits into from
Jan 4, 2022

Conversation

ponytailer
Copy link
Contributor

@ponytailer ponytailer commented Dec 29, 2021

  • throw the errors earlier
  • common line_length = 79 in black config

@abersheeran
Copy link
Owner

To be honest, I don't like the 79 limit, so I didn't configure this option before.

ratelimit/core.py Outdated Show resolved Hide resolved
ratelimit/core.py Outdated Show resolved Hide resolved
@ponytailer
Copy link
Contributor Author

To be honest, I don't like the 79 limit, so I didn't configure this option before.

ok, I remove it.

ratelimit/core.py Outdated Show resolved Hide resolved
@ponytailer
Copy link
Contributor Author

ponytailer commented Jan 4, 2022

BTW, can support simple rate-limit in memory? It can test the project quickly without redis

@abersheeran
Copy link
Owner

Yes, we can add a new memory backend. In fact, I wanted to add this function at first, but I've been busy with other work. If you are willing to submit PR, I will be happy to help you complete it together.

@ponytailer
Copy link
Contributor Author

Yes, we can add a new memory backend. In fact, I wanted to add this function at first, but I've been busy with other work. If you are willing to submit PR, I will be happy to help you complete it together.

OK, I will add it later.

@abersheeran abersheeran merged commit 504de6d into abersheeran:master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants