Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to change their email address. #185

Closed
Jas0n99 opened this issue Jan 23, 2020 · 6 comments
Closed

Allow users to change their email address. #185

Jas0n99 opened this issue Jan 23, 2020 · 6 comments
Labels
Milestone

Comments

@Jas0n99
Copy link

Jas0n99 commented Jan 23, 2020

There needs to be a main account page for a user to update their email address (globally) that would also update all team accounts.

The new system allows for multiple accounts, and a person can invite their new email address to each, but that seems a very roundabout way to do it, and also requires an admin to remove the old emails.

Just something for the future to-do...

@Jas0n99
Copy link
Author

Jas0n99 commented Jan 23, 2020

Nevermind, just saw it was a dupe of #154

@Jas0n99 Jas0n99 closed this as completed Jan 23, 2020
@abh abh reopened this Jan 23, 2020
@abh
Copy link
Owner

abh commented Jan 23, 2020

#154 is just the password, no?

Changing the email is tricky if your login was via one of the 3rd party logins (because then the email address comes from there). Inviting the new address works around that (and I think when the admin does it, it's a little more explicit ...). Shrug.

@Jas0n99
Copy link
Author

Jas0n99 commented Jan 23, 2020

Oh yeah, I didn't think about the interaction of accounts that authenticate with the 3rd parties.

You're right, the current invite method is probably the best for now, it's not that often someone requests to have their email address changed.

@abh abh added this to the v3.0 milestone Feb 19, 2020
@abh abh added the website label Feb 19, 2020
@abh abh closed this as completed in 6a29d41 Feb 21, 2020
@abh
Copy link
Owner

abh commented Feb 21, 2020

Workaround live on beta site: https://manage-beta.grundclock.com/manage/account

@Jas0n99
Copy link
Author

Jas0n99 commented Feb 22, 2020

I'm not sure what the workaround is? I saw the text on the Account Information page, "To change your email address, add the new address to the team and login to remove the old address."

I used my non-admin account to test, and even after adding a second email address I do not see the boxes to remove any email addresses.

I also noticed on the Account Management page it says, "To remove a user from the account, please email ..." So that seems a little conflicting?

abh added a commit that referenced this issue Mar 2, 2020
(email is sent to the removed user and other users on the account)

(closes #185 properly?)
@abh
Copy link
Owner

abh commented Mar 2, 2020

@Jas0n99 thank you -- I totally forgot that regular users can't remove email addresses from the account. Fixed now, on the beta site. I forgot to fix the conflicting text though.

abh added a commit that referenced this issue Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants