Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CamGear: Replaced Youtube-DL with yt-dlp #261

Closed
abhiTronix opened this issue Oct 26, 2021 · 1 comment · Fixed by #262
Closed

CamGear: Replaced Youtube-DL with yt-dlp #261

abhiTronix opened this issue Oct 26, 2021 · 1 comment · Fixed by #262
Assignees
@abhiTronix
Labels
ENHANCEMENT ⚡ New Feature/Addition/Improvement PROPOSAL 📩 A proposal/proposition SOLVED 🏁 This issue/PR is resolved now. Goal Achieved!
Projects
VidGear v0.2.3
Milestone
0.2.3

Comments

@abhiTronix
Copy link
Owner

Detailed Description

Due to mostly inactive youtube-dl project(last released on youtube-dl 2021.06.06) that results in new bugs, pipelining youtube videos with CamGear API is becoming extremely difficult day by day. Therefore we are planning to move to its latest and constantly updating fork yt-dlp project for future usage.

Context

yt-dlp is a youtube-dl fork based on the now inactive youtube-dlc. The main focus of this project is adding new features and patches while also keeping up to date with the original project. This issue will track smooth transition from youtube-dl to yt-dlp as pafy backend, which also serves as CamGear API backend for youtube videos pipelining.

Your Current Environment

  • VidGear version: v0.2.3
  • Branch: testing
  • Python version: all
  • Operating System and version: all

Any Other Important Information

Pafy does not support yt-dlp nor there's a alternative for pafy. But good thing is that yt-dlp python API functions exactly similar to youtube-dl, so we can defy pafy to think yt-dlp as youtube-dl using sys.module trick.
@abhiTronix abhiTronix added ENHANCEMENT ⚡ New Feature/Addition/Improvement WORK IN PROGRESS 🚧 currently been worked on. PROPOSAL 📩 A proposal/proposition labels Oct 26, 2021
@abhiTronix abhiTronix added this to the 0.2.3 milestone Oct 26, 2021
@abhiTronix abhiTronix self-assigned this Oct 26, 2021
@abhiTronix abhiTronix added this to To do issues in VidGear v0.2.3 via automation Oct 26, 2021
abhiTronix added a commit that referenced this issue Oct 26, 2021
@abhiTronix
⚡️ CamGear: Replaced youtube-dl with yt-dlp as pafy backend. (Fixes
e80e114 
#261)

- ⚡️ Implemented hack to trick pafy into assuming `yt-dlp` as `youtube-dl`.
- 🚑️ Using `sys.modules` to present `yt-dlp` as `youtube-dl`.
- ⚡️ `yt-dlp` is a youtube-dl fork based on the now inactive youtube-dlc.
- ⚡️ `yt-dlp` python API functions exactly similar to `youtube-dl`.
- ➕ Replaced `youtube-dl` dependency with `yt-dlp`.
- ➕ Replaced `youtube-dl` imports with `yt-dlp`.
- 📝 Updated docs and code comments.
@abhiTronix abhiTronix pinned this issue Oct 26, 2021
@abhiTronix abhiTronix mentioned this issue Oct 27, 2021
Merged
6 tasks
@abhiTronix abhiTronix linked a pull request Oct 27, 2021 that will close this issue
Release VidGear Stable v0.2.3 #262
Merged
6 tasks
@abhiTronix abhiTronix changed the title CamGear: Replace Youtube-DL with yt-dlp CamGear: Replaced Youtube-DL with yt-dlp Oct 27, 2021
VidGear v0.2.3 automation moved this from To do issues to Done Oct 27, 2021
@abhiTronix
Copy link
Owner Author

Successfully resolved and merged in commit 99ffcec

@abhiTronix abhiTronix added SOLVED 🏁 This issue/PR is resolved now. Goal Achieved! and removed WORK IN PROGRESS 🚧 currently been worked on. labels Oct 27, 2021
@abhiTronix abhiTronix unpinned this issue Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhiTronix abhiTronix

Labels
ENHANCEMENT ⚡ New Feature/Addition/Improvement PROPOSAL 📩 A proposal/proposition SOLVED 🏁 This issue/PR is resolved now. Goal Achieved!
Projects
No open projects
VidGear v0.2.3
Done
Milestone
0.2.3
Development

Successfully merging a pull request may close this issue.

Release VidGear Stable v0.2.3 abhiTronix/vidgear
1 participant
@abhiTronix