Skip to content
This repository has been archived by the owner on Jul 28, 2021. It is now read-only.

Enhancement: Ratings UI Improved #56

Closed
wants to merge 36 commits into from

Conversation

mishal23
Copy link
Contributor

Status

Ready

Description

The rating UI is improved and provides more functionality and control on the web admin to decide who would rate the extension (for eg. only once a user can rate, only authenticated users can rate)

ToDos

  • Python 2&3 Support
  • PEP-8
  • Master branch up-to-date
  • Tested Locally

Steps to Test or Reproduce

Run the Django App locally, create necessary apps, and then try to rate the app

Deploy Notes

Ensure django-star-ratings is installed on the production server.

… to path, ported to Django2.0, updated the packages
* user guide

* added more information from the app-store-overview

* added numbers, and details markdown to improve readibility

Port the ns-3 AppStore to Python3 and Django 2.0 (abhijithanilkumar#47)

* migrated from python2.7 to python3.6, url convention changed from url to path, ported to Django2.0, updated the packages

* code formatted according to PEP 8 style guide

* updated versions for packages in base.txt

* fix releases form to support file upload

* removed all commented lines after testing

migrated from python2.7 to python3.6, url convention changed from url to path, ported to Django2.0, updated the packages

code formatted according to PEP 8 style guide

removed all commented lines after testing
* migrated from python2.7 to python3.6, url convention changed from url to path, ported to Django2.0, updated the packages

* code formatted according to PEP 8 style guide

* updated versions for packages in base.txt

* fix releases form to support file upload

* removed all commented lines after testing

* REST API started for install

* install api core logic

* modified install API to take care of empty bakefile

* APIs protected by setting rate limits

* added REST API for search functionality

* modified the search API to use ?

* added restframework in requirements:base.txt

* added api documentation

* changed formatting for APs

* added tabs for API docs

* made changes to font-weight

* added ns version to the install API

* Added User Guide (abhijithanilkumar#45)

* user guide

* added more information from the app-store-overview

* added numbers, and details markdown to improve readibility

Port the ns-3 AppStore to Python3 and Django 2.0 (abhijithanilkumar#47)

* migrated from python2.7 to python3.6, url convention changed from url to path, ported to Django2.0, updated the packages

* code formatted according to PEP 8 style guide

* updated versions for packages in base.txt

* fix releases form to support file upload

* removed all commented lines after testing

migrated from python2.7 to python3.6, url convention changed from url to path, ported to Django2.0, updated the packages

code formatted according to PEP 8 style guide

removed all commented lines after testing

* removed extra lines

* modified the install API to use serializers

* changed code to follow PEP8 guidelines

* modified the install API logic to use get_object_or_404

* Search API changed to use viewsets, WIP: version parameter in response

* viewset for search API implemented along with the version

* code changed to follow PEP8 guidelines

* added throttling for search API

* added status codes for the response in search API

* updated API Documentation

* search API modified to send all the apps info for list in Bake

* pagination started

* pagination implemented for search API

* changed the default page size to 20

Feature: Search filter for Categories & App Type added (abhijithanilkumar#49)

* migrated from python2.7 to python3.6, url convention changed from url to path, ported to Django2.0, updated the packages

updated versions for packages in base.txt

fix releases form to support file upload

removed all commented lines after testing

REST API started for install

install api core logic

modified install API to take care of empty bakefile

modified the search API to use ?

added restframework in requirements:base.txt

made changes to font-weight

Added User Guide (abhijithanilkumar#45)

* user guide

* added more information from the app-store-overview

* added numbers, and details markdown to improve readibility

Port the ns-3 AppStore to Python3 and Django 2.0 (abhijithanilkumar#47)

* migrated from python2.7 to python3.6, url convention changed from url to path, ported to Django2.0, updated the packages

* code formatted according to PEP 8 style guide

* updated versions for packages in base.txt

* fix releases form to support file upload

* removed all commented lines after testing

migrated from python2.7 to python3.6, url convention changed from url to path, ported to Django2.0, updated the packages

code formatted according to PEP 8 style guide

removed all commented lines after testing

removed extra lines

modified the install API to use serializers

changed code to follow PEP8 guidelines

Search API changed to use viewsets, WIP: version parameter in response

viewset for search API implemented along with the version

updated API Documentation

view all forks, utilities added

added forks and utlities link in nav panel

search API modified to send all the apps info for list in Bake

added search filters for categories and app type, removed print statements

pagination started

merge conflicts resolved

* added forks and utlities link in nav panel

* added search filters for categories and app type, removed print statements

* removed same import code

* code modified as per PEP8 huideline

* removed extra space

* fixed extra line

* fixed extra lines

* commented out the search filter code

* filters changed to follow JS and alongwith the sort by option

* added space after the filter by word

* removed the extra padding in the app_button, full class

* alignments fixed, comments added

* removed the crispy form tag

* added message in case of no results are found

github OAuth2 added

added gitlab oauth

modified the frontend for oauth login page

oauth user after login assigned to group

view for list of moderated users done, delete implemented

enabled changing groups for admin, custom permissions tested for create ap

download app created for statistics

core logic for app download stats datewise and total total

download stats done templates, overall stats detailed stats done
@abhijithanilkumar
Copy link
Owner

Can you add a screenshot for this? Did you make the changes suggested during the last call?

Copy link
Owner

@abhijithanilkumar abhijithanilkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments!

from django.apps import AppConfig


class DownloadConfig(AppConfig):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

@@ -10,6 +10,7 @@
# from django.core.urlresolvers import reverse_lazy
from django.urls import reverse_lazy
from os.path import dirname, join, exists
import rest_framework

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this?

@@ -75,8 +75,4 @@
'api/search/',
views_api.SearchApiViewSet.as_view({'post': 'create'}),
name='search'),
path(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional?

@mishal23 mishal23 closed this Aug 25, 2019
@mishal23 mishal23 deleted the ratings branch August 25, 2019 17:45
@mishal23
Copy link
Contributor Author

Cumulative merged in #59

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants