Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrate to prettyprinter #18

Merged
merged 2 commits into from
Apr 6, 2024

Conversation

414owen
Copy link
Contributor

@414owen 414owen commented Apr 4, 2024

The ecosystem seems to be moving towards prettyprinter, to the extent that it seems easier to build packages which depend on prettyprinter, rather than ansi-wl-pprint.

This is a breaking change, by virtue of the removal of Pretty instances.

I think you currently have to choose between backend-specific features or a Pretty instance, with prettyprinter.

haskell/actions/setup is deprecated in favor of haskell-actions/setup.
Copy link
Owner

@abhinav abhinav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
The Windows breakage doesn't really seem related to this.
I'm happy to merge this as-is at this point.

@abhinav abhinav merged commit 9c9fb41 into abhinav:master Apr 6, 2024
4 of 5 checks passed
@abhinav
Copy link
Owner

abhinav commented Apr 6, 2024

@414owen
Copy link
Contributor Author

414owen commented Apr 6, 2024

@abhinav thank you very much! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants