Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace AbstractJikan with utility functions #71

Closed
abhinavk99 opened this issue May 18, 2020 · 0 comments
Closed

Replace AbstractJikan with utility functions #71

abhinavk99 opened this issue May 18, 2020 · 0 comments
Assignees

Comments

@abhinavk99
Copy link
Owner

abhinavk99 commented May 18, 2020

Reasons

  1. AioJikan methods aren't really overriding AbstractJikan methods because async def can't override def according to mypy.
  2. AioJikan needs to reimplement methods in AbstractJikan like _wrap_response.
  3. URL getting methods in AbstractJikan can become utility functions.
  4. It'll make it easier to allow different kwargs in for session headers in the Jikan and AioJikan constructors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant