Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified examples, fixed top method error, and added tests #33

Merged
merged 3 commits into from
Jan 20, 2019

Conversation

abhinavk99
Copy link
Owner

  • Added pprint to examples
  • Replaced asyncio.coroutine with async/await syntax in async examples (no more 3.4 support)
  • Added error if subtype given without page for top method
  • Added tests to improve coverage

@abhinavk99
Copy link
Owner Author

For #32

@codecov-io
Copy link

codecov-io commented Jan 20, 2019

Codecov Report

Merging #33 into master will increase coverage by 9.3%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #33     +/-   ##
=========================================
+ Coverage   85.92%   95.23%   +9.3%     
=========================================
  Files           6        6             
  Lines         334      336      +2     
=========================================
+ Hits          287      320     +33     
+ Misses         47       16     -31
Impacted Files Coverage Δ
jikanpy/abstractjikan.py 90.58% <100%> (+17.96%) ⬆️
jikanpy/aiojikan.py 100% <0%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d0142...cac1e59. Read the comment docs.

@abhinavk99 abhinavk99 merged commit e99ae9b into master Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants