Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.2.0 - Revamped APIException, fixed error handling HTTP responses, and refactoring #80

Merged
merged 9 commits into from
Jun 11, 2020

Conversation

abhinavk99
Copy link
Owner

@abhinavk99 abhinavk99 commented Jun 11, 2020

From CHANGELOG.md

[4.2.0] - 2020-06-10

Added

Changed

Fixed

  • Bug where jikanpy would crash when the JSON response can't be decoded with the simplejson JSON parser
  • Bug where jikanpy would crash when the JSON response is a list instead of a dict

@abhinavk99 abhinavk99 self-assigned this Jun 11, 2020
…and refactoring

Added __init__ to documentation
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2020

Codecov Report

Merging #80 into master will decrease coverage by 0.81%.
The diff coverage is 98.91%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #80      +/-   ##
===========================================
- Coverage   100.00%   99.18%   -0.82%     
===========================================
  Files            5        5              
  Lines          251      244       -7     
===========================================
- Hits           251      242       -9     
- Misses           0        2       +2     
Impacted Files Coverage Δ
jikanpy/aiojikan.py 97.70% <97.22%> (-2.30%) ⬇️
jikanpy/__init__.py 100.00% <100.00%> (ø)
jikanpy/exceptions.py 100.00% <100.00%> (ø)
jikanpy/jikan.py 100.00% <100.00%> (ø)
jikanpy/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3d9685...b29e35d. Read the comment docs.

@abhinavk99 abhinavk99 merged commit a429605 into master Jun 11, 2020
@abhinavk99 abhinavk99 deleted the dev branch June 11, 2020 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants