Skip to content

Commit

Permalink
Bump min versions of openapi validators (apache#37691)
Browse files Browse the repository at this point in the history
The openapi validators in older versions do not work well for some
moto tests which use the validators. Bumping specifically the
min versions of those validators should help with better
dependency resolving (wheb using uv and lowest transitive versions
strategy it will downgrade the validators and will cause the tests
to fail as seen in apache#37683.

Those are only test and development dependencies and we already use
the min version specified in our CI, so it should have no impact
on production airflow (but should help wiht CI/dependency resolution)
  • Loading branch information
potiuk authored and abhishekbhakat committed Mar 5, 2024
1 parent 008b8a6 commit c78bd61
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ repos:
name: Lint OpenAPI using openapi-spec-validator
entry: openapi-spec-validator --schema 3.0.0
language: python
additional_dependencies: ['openapi-spec-validator>=0.6.0']
additional_dependencies: ['openapi-spec-validator>=0.7.1', 'openapi-schema-validator>=0.6.2']
files: ^airflow/api_connexion/openapi/
- id: lint-dockerfile
name: Lint Dockerfile
Expand Down
2 changes: 2 additions & 0 deletions airflow/providers/amazon/provider.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,8 @@ devel-dependencies:
- mypy-boto3-redshift-data>=1.33.0
- mypy-boto3-s3>=1.33.0
- s3fs>=2023.10.0
- openapi-schema-validator>=0.6.2
- openapi-spec-validator>=0.7.1

integrations:
- integration-name: Amazon Athena
Expand Down
4 changes: 3 additions & 1 deletion generated/provider_dependencies.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@
"mypy-boto3-rds>=1.33.0",
"mypy-boto3-redshift-data>=1.33.0",
"mypy-boto3-s3>=1.33.0",
"s3fs>=2023.10.0"
"s3fs>=2023.10.0",
"openapi-schema-validator>=0.6.2",
"openapi-spec-validator>=0.7.1"
],
"cross-providers-deps": [
"apache.hive",
Expand Down
2 changes: 2 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -565,6 +565,8 @@ amazon = [ # source: airflow/providers/amazon/provider.yaml
"mypy-boto3-redshift-data>=1.33.0",
"mypy-boto3-s3>=1.33.0",
"s3fs>=2023.10.0",
"openapi-schema-validator>=0.6.2",
"openapi-spec-validator>=0.7.1",
]
apache-beam = [ # source: airflow/providers/apache/beam/provider.yaml
"apache-beam>=2.53.0;python_version != \"3.12\"",
Expand Down

0 comments on commit c78bd61

Please sign in to comment.