Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace jquery.cookie with js-cookie #147

Closed
jcoyne opened this issue Sep 10, 2015 · 2 comments
Closed

Replace jquery.cookie with js-cookie #147

jcoyne opened this issue Sep 10, 2015 · 2 comments
Assignees
@sebastiankelle
Labels
enhancement - high priority

Comments

@jcoyne
Copy link

jcoyne commented Sep 10, 2015

According to the github repo https://github.com/carhartl/jquery-cookie jquery.cookie is no longer maintained and has been superseded by js-cookie https://github.com/js-cookie/js-cookie
sebastiankelle pushed a commit to sebastiankelle/ableplayer that referenced this issue Nov 29, 2015
@sebastiankelle
Replace outdated jquery cookie with this (see issue ableplayer#147). …
d04059e 
…Needs this file in third party folder.
sebastiankelle pushed a commit to sebastiankelle/ableplayer that referenced this issue Dec 5, 2015
@sebastiankelle
Replace outdated jquery cookie with this (see issue ableplayer#147). …
89a4690 
…Needs this file in third party folder.
sebastiankelle pushed a commit to sebastiankelle/ableplayer that referenced this issue Dec 8, 2015
@sebastiankelle
Replace outdated jquery cookie with this (see issue ableplayer#147). …
2b77ab5 
…Needs this file in third party folder.
sebastiankelle added a commit to sebastiankelle/ableplayer that referenced this issue Dec 8, 2015
@sebastiankelle
fix issue ableplayer#147
581ce88
sebastiankelle added a commit to sebastiankelle/ableplayer that referenced this issue Dec 8, 2015
@sebastiankelle
resubmit fix issue ableplayer#147
41cb70a
sebastiankelle added a commit to sebastiankelle/ableplayer that referenced this issue Dec 8, 2015
@sebastiankelle
fix issue ableplayer#147
9ec2a61
sebastiankelle added a commit to sebastiankelle/ableplayer that referenced this issue Dec 8, 2015
@sebastiankelle
more changes re. solving final detail in ableplayer#147
54db63d
sebastiankelle added a commit to sebastiankelle/ableplayer that referenced this issue Dec 8, 2015
@sebastiankelle
Resumit fix for ableplayer#147: cookie now expires after 90 days.
68df568
sebastiankelle added a commit to sebastiankelle/ableplayer that referenced this issue Dec 8, 2015
@sebastiankelle
Resumit fix for ableplayer#147: cookie now expires after 90 days.
403d010
terrill added a commit that referenced this issue Dec 9, 2015
@terrill
Merge pull request #179 from sebastiankelle/develop
d99ef84 
resubmit fix issue #147
@terrill
Copy link
Member

terrill commented Dec 9, 2015

Complete with d99ef84
Tested in Firefox and Chrome on Mac; and Firefox, Chrome, and IE on Windows

@terrill terrill closed this as completed Dec 9, 2015
@Aybee
Copy link

Aybee commented Apr 30, 2016

Please change text in README.md
Headline: Setup Step 2: Add JavaScript and CSS
jquery.cookie.js => js.cookie.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastiankelle sebastiankelle

Labels
enhancement - high priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jcoyne @terrill @Aybee @sebastiankelle