Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to observe raw locations change in Subscriber SDK #274

Merged
merged 6 commits into from
Mar 18, 2022
Merged

Add ability to observe raw locations change in Subscriber SDK #274

merged 6 commits into from
Mar 18, 2022

Conversation

lukasz-szyszkowski
Copy link
Contributor

No description provided.

@github-actions github-actions bot temporarily deployed to staging/pull/274/jazzy March 10, 2022 12:16 Inactive
@lukasz-szyszkowski lukasz-szyszkowski linked an issue Mar 10, 2022 that may be closed by this pull request
Add ability to observe raw locations change in Subscriber SDK #272
Closed
KacperKluka
KacperKluka suggested changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@KacperKluka KacperKluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few small suggestions 😉

Sources/AblyAssetTrackingSubscriber/SubscriberDelegate.swift Outdated Show resolved Hide resolved
Examples/SubscriberExample/Sources/Screens/Map/MapViewController.swift Outdated Show resolved Hide resolved
KacperKluka
KacperKluka approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@KacperKluka KacperKluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot temporarily deployed to staging/pull/274/jazzy March 11, 2022 08:27 Inactive
@QuintinWillison QuintinWillison removed their request for review March 14, 2022 16:05
@maratal
Copy link
Collaborator

maratal commented Mar 17, 2022

LGTM

@lukasz-szyszkowski lukasz-szyszkowski merged commit 6465f7a into main Mar 18, 2022
@lukasz-szyszkowski lukasz-szyszkowski deleted the feature/272-add-ability-to-observe-raw-locations branch March 18, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maratal maratal maratal approved these changes

@KacperKluka KacperKluka KacperKluka approved these changes

@lawrence-forooghian lawrence-forooghian Awaiting requested review from lawrence-forooghian

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to observe raw locations change in Subscriber SDK
3 participants
@lukasz-szyszkowski @maratal @KacperKluka